Opened 10 years ago

Closed 10 years ago

#1349 closed bug (fixed (in master))

Superfluous & in call of memset() for known flags in rd_item()

Reported by: Zaxx Owned by:
Milestone: 3.3.0 Keywords: cleanup
Cc:

Description

Proper fix: use the new of_wipe() method

I've seen a few other memset() calls in the code for known flags. They could be replaced by calls to of_wipe() and of_setall().

Change History (4)

comment:1 Changed 10 years ago by d_m

Would you care to submit a patch? I would be happy to apply it. Otherwise, I will try to take a look at this when I get a chance.

comment:2 Changed 10 years ago by Zaxx

File load.c, method rd_item2(), line 112, replace the line (with memset) by this line:

of_wipe(o_ptr->known_flags);

comment:3 Changed 10 years ago by d_m

  • Status changed from new to pending

Fixed the uses of memset in this way in load.c and object/identify.c

Thanks!

comment:4 Changed 10 years ago by magnate

  • Keywords cleanup added
  • Milestone changed from Triage to 3.3.0
  • Resolution set to fixed
  • Status changed from pending to closed

Now in master, [rcb74d440]

Note: See TracTickets for help on using tickets.