Opened 13 years ago

Closed 13 years ago

#344 closed bug (fixed (in master))

p_ptr->command_wrk not reset in get_item()

Reported by: Big Al Owned by:
Milestone: 3.1.0 Keywords: waiting ui


If you do an action that requires the selection of an item, and the inventory list pops up by default, then you get odd behavior occasionally regarding browsing inventory vs. equipment.

Eg, in a shop:

  • Press 'd' to sell an item; it (normally) shows you a list of your inventory that you can sell.
  • Then, you can press '/' to view your equipment that you can sell.
  • Sell an item (or just cancel the prompt).
  • Press 'd' again to sell another item; it now shows the list of equipment that you can sell, not the inventory as expected.

I think adding p_ptr->command_wrk = FALSE; to somewhere near the end of get_item() should fix it.

Change History (7)

comment:1 Changed 13 years ago by takkaria

This is the way it works everywhere -- try it with the 'I' command outside the store. I think this is an intentional feature.

comment:2 Changed 13 years ago by takkaria

  • Keywords waiting added

comment:3 Changed 13 years ago by Big Al

If it's designed to be like that, then I guess that's ok, but I generally like things consistent. If I want to drop object 'e' in the inventory, I feel as though I should be able to press 'de' to drop it, rather than press 'd', check if I'm on the inv or equip screen (that I may or may not have changed five minutes ago), press '/' if necessary, then press 'e'. Seems more complex this way.

comment:4 Changed 13 years ago by takkaria

  • Milestone changed from 3.2.0 to 3.1.0

comment:5 Changed 13 years ago by takkaria

  • Resolution set to wontfix
  • Status changed from new to closed

The feature is actually useful when e.g. examining objects in your equipment, and seeing as I haven't changed this, I'm wontfixing this bug.

comment:6 Changed 13 years ago by takkaria

  • Resolution wontfix deleted
  • Status changed from closed to reopened

My bad. I initially thought this was a good thing, turns out it's not. Fix in the pipeline.

comment:7 Changed 13 years ago by takkaria

  • Resolution set to fixed
  • Status changed from reopened to closed

Fix in [5357a17] (SVN r715). If you have any further problems, please file a new bug. Thanks!

Note: See TracTickets for help on using tickets.