Opened 12 years ago

Closed 12 years ago

#429 closed bug (fixed (in master))

Unused flags in defines.h

Reported by: Kenneth 'Bessarion' Boyd <zaimoni@…> Owned by:
Milestone: 3.1.0 Keywords:


1) the MDESC_ family of flags is completely unused in the *.c files; looks like they should be used (bitvector style) to obviate non-zero magic constants for monster_desc.

2) MON_SUMMON_ADJ isn't used either. While it is the correct denominator for the summoned monster level calculation, I don't see how any clarity is to be gained from it (denominator is standard for arithmetic mean). I have eliminated this for Zaiband.

Change History (2)

comment:1 Changed 12 years ago by takkaria

second part fixed in [15c7917] (SVN r655).

comment:2 Changed 12 years ago by takkaria

  • Milestone changed from 3.2.0 to 3.1.0
  • Resolution set to fixed
  • Status changed from new to closed

See [1c19a1a] (SVN r656) for the first part; some of those flags are still unused, though. monster_desc() is still a very unclear function, though.

Note: See TracTickets for help on using tickets.