Opened 12 years ago

Closed 6 years ago

#589 closed bug (fixed (in master))

Identify spell should check that there are items to identify before checking mana

Reported by: takkaria Owned by: magnate
Milestone: 3.5.0 Keywords: id
Cc:

Description

This is a more general issue with the current spells system; perhaps it can be fixed if spells were to move to the effects.c framework.

Change History (9)

comment:1 Changed 11 years ago by magnate

  • Keywords id added

comment:2 Changed 10 years ago by magnate

See also #980.

comment:3 Changed 10 years ago by MarbleDice

This is a problem with identify effects as well. When using a staff or rod, failure is checked before unknown items, so it is possible to fail your device check and lose that turn when you don't have anything to identify.

comment:4 follow-up: Changed 10 years ago by magnate

  • Status changed from new to confirmed

Thanks for the heads-up. I'll see if I can re-order this as part of #715.

comment:5 in reply to: ↑ 4 Changed 10 years ago by magnate

  • Owner set to magnate
  • Status changed from confirmed to assigned

Replying to magnate:

Thanks for the heads-up. I'll see if I can re-order this as part of #715.

Nope, forgot to do that. So closing this ticket requires checking for unknown items first, before checking for mana or device success.

comment:6 Changed 9 years ago by magnate

  • Milestone changed from 4.0 to 3.3.0

comment:7 Changed 9 years ago by magnate

  • Milestone changed from 3.3.0 to Future
  • Status changed from assigned to confirmed

Punting in accordance with new milestone policy (that any other milestone is only set once someone is actually working on the ticket).

comment:8 Changed 7 years ago by takkaria

  • Milestone changed from Future to 3.5.0

Assigning still-open bugs from Future to 3.5 for fixing.

comment:9 Changed 6 years ago by takkaria

  • Resolution set to fixed (in master)
  • Status changed from confirmed to closed

Fixed in b020e2c, pull request ​https://github.com/angband/angband/pull/276

Note: See TracTickets for help on using tickets.