Opened 10 years ago
Closed 9 years ago
#998 closed bug (fixed (in master))
Windows compiler warnings
Reported by: | MarbleDice | Owned by: | MarbleDice |
---|---|---|---|
Milestone: | 3.2.0 | Keywords: | windows |
Cc: |
Description
I get quite a few compiler warnings on Windows with the default build:
make -f Makefile.win
See attached.
Attachments (1)
Change History (9)
Changed 10 years ago by MarbleDice
comment:1 Changed 10 years ago by MarbleDice
[b9b0eef] (SVN r1755) addresses some other warnings, but all of the warnings in the attached file are still present.
comment:2 Changed 10 years ago by magnate
Takkaria: grateful for any advice on how to make gcc display these warnings - I don't get any using the default build (./autogen.sh, ./configure, make).
comment:3 Changed 10 years ago by magnate
- Milestone changed from Triage to 3.1.2 beta
comment:4 Changed 10 years ago by anonymous
"-Wno-unused-parameter -Wno-missing-field-initializers" should be in the warning flags in Makefile.win, because they turn off most of these. Also,
46 init1.c:999: warning: implicit declaration of function `strdup'
The fix here is to use string_make() instead of strdup(), not to cast strdup() to char pointer.
comment:5 Changed 10 years ago by MarbleDice
[65451a5] (SVN r1765) deals with most of the rest. The only remaining warning I get with Makefile.win is:
z-file.c: In function `file_read': z-file.c:517: warning: implicit declaration of function `fileno'
comment:6 Changed 10 years ago by MarbleDice
- Owner set to MarbleDice
- Status changed from new to assigned
comment:7 Changed 10 years ago by MarbleDice
- Milestone changed from 3.1.2 beta to Future
[b377dbc] (SVN r1875) adds -Wextra to the Windows makefile.
comment:8 Changed 9 years ago by takkaria
- Keywords compat removed
- Milestone changed from Future to 3.2.0
- Resolution set to fixed
- Status changed from assigned to closed
all build warnings gone now.
Windows compiler warnings.